Skip to content

feat: claim and release w3n helpers #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 16, 2024
Merged

feat: claim and release w3n helpers #875

merged 4 commits into from
Jul 16, 2024

Conversation

rflechtner
Copy link
Contributor

fixes KILTProtocol/ticket#3372

fixes KILTProtocol/ticket#3515

Implements claimWeb3Name & releaseWeb3Name and adds integration tests for both.

Also fixes a bug in matching module errors.

How to test:

Rudimentary unit test and basic integration tests are included.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@rflechtner rflechtner requested a review from abdulmth July 16, 2024 14:05
@abdulmth abdulmth merged commit f486f19 into rf-did-helpers Jul 16, 2024
1 check passed
@abdulmth abdulmth deleted the rf-claim-w3n branch July 16, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdulmth abdulmth abdulmth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rflechtner @abdulmth